DataBiosphere / data-browser

Apache License 2.0
11 stars 4 forks source link

[HCA DX] Track clicks on export request buttons #4191

Open MillenniumFalconMechanic opened 1 month ago

MillenniumFalconMechanic commented 1 month ago

Need

We need to track clicks on export buttons such as "Request Link" for export to Terra, and "Prepare Manifest" for file manifest.

Approach

Investigate reuse of curl download event. See comments below for approach.

Definition of Done

Needs

Validation

curl Command

File Manifest

Export to Terra

jpaten commented 1 month ago

Hi @MillenniumFalconMechanic! I took a look through the existing bulk_download_requested event, and I think it could be reused, but I found several issues that would need to be considered:

Let me know if you what you think about this, and I can make a findable ticket to add these changes and call the event on other existing events

MillenniumFalconMechanic commented 1 month ago
MillenniumFalconMechanic commented 1 month ago

Hi @jpaten, the corresponding PR has been merged and deployed to dev.

jpaten commented 1 month ago

Thanks @MillenniumFalconMechanic!

jpaten commented 1 month ago

@MillenniumFalconMechanic I'm so sorry, I realized I mistagged the corresponding PR #4201 , which should have been associated with #4181! This shouldn't require any action though, because this ticket does not require any code changes to the data-browser repo. The only code changes are in https://github.com/DataBiosphere/findable-ui/pull/224. Once that's reviewed, I'll go ahead and create a GTM version for this ticket, and comment it here. So sorry again for the confusion!

MillenniumFalconMechanic commented 1 week ago

Hi @jpaten, Findable 14.0.0 has been deployed to dev. Can you continue with the configuration and testing against dev while we wait for the prod deploy?

jpaten commented 1 week ago

Hi @MillenniumFalconMechanic! Yep, I can do that

jpaten commented 1 week ago

Version #62 on GTM