DataBiosphere / data-explorer

BSD 3-Clause "New" or "Revised" License
11 stars 6 forks source link

Fix SQL query for exporting Samples Overview facet #196

Closed bfcrampton closed 6 years ago

bfcrampton commented 6 years ago

Facets which reference fields from different columns/tables are now handled correctly. Currently this is only the Samples Overview facet, but it will work with any FiltersFacet in the future.

Verified the export works for Samples Overview when the fields are in different tables by duplicating the 1000 genomes samples table and referencing one of those fields in the overview facet. The proper FULL JOIN statement is generated and the correct number of participants were returned.

bfcrampton commented 6 years ago

Resolves https://github.com/DataBiosphere/data-explorer/issues/197