Add chip when checking/unchecking facet value

DataBiosphere / data-explorer

BSD 3-Clause "New" or "Revised" License

11 stars 6 forks source link

Add chip when checking/unchecking facet value #213

Closed malathi13 closed 5 years ago

malathi13 commented 6 years ago

Add a chip when checking a facet value from facet card.
Remove chip when unchecking a facet value from facet card.
Clicking on the 'x' mark in the chip removes the chip.

melissachang commented 6 years ago

As discussed, the PR would need the following changes to be usable (able to be deployed on production) IMO:

Clicking x on chips work
Formatting of row text

This PR is quite big, can you do #202 first? That's a way of breaking up the work that's still usable. I'm open to other ways of breaking up the work.

melissachang commented 6 years ago

I spent some more time debugging the waitForXPath() issue. (It would be a pretty serious Puppeteer bug if waitForXPath() didn't work.)

await page.waitForXPath("//span[contains(text(), facetName)]");

I think the problem is, we are looking for the string facetName. Does it work if you hard-code Avuncular?