Fix filtering with negative numbers - Githubissues

DataBiosphere / data-explorer

BSD 3-Clause "New" or "Revised" License

11 stars 6 forks source link

Fix filtering with negative numbers #233

Closed melissachang closed 5 years ago

melissachang commented 5 years ago

I am deploying the fix to https://baseline-baseline-explorer.appspot.com/, so these bugs can only be reproed locally.

Bug 1 - Filtering broken with negative numbers

In Baseline Baseline data explorer, add facet predicted_actual_age_diff
Click "-20--10".
Facets don't update as expected

Bug 2 - Chips don't show correctly for facets added by search box

Add a facet with search box
Click a value in newly added facet
Chip shows "undefined=value"

A future PR will add e2e test for Bug 2.