search

DataBiosphere / data-explorer

BSD 3-Clause "New" or "Revised" License
11 stars 6 forks source link

Move facet scrollbar to the right #257

Closed melissachang closed 5 years ago

melissachang commented 5 years ago

On Linux, the scrollbar appears right next to facet value counts: linux

The scrollbar should be moved to the right so there is some space.

On Mac, the scrollbar doesn't appear by default: mac

On Mac during scrolling, the scrollbar appears on top of facet value counts. So moving the scrollbar to the right is better for Mac also.

For Mac, is it possible to get scrollbar to appear by default? So people know that not all facet values are shown.

wnojopra commented 5 years ago

@melissachang Are both those screenshots using Chrome? Or is the Mac one using Safari? In general, I we can change things for browsers (or more specifically, browser features).

There's a setting you can toggle on Mac to make the scrollbar always appear: https://www.lifewire.com/change-how-macs-scroll-bars-work-2260834 .

We currently set overflow-y to 'auto' in FacetsGrid.css, which I think is the right thing to do. It will cause a scrollbar to appear if the content is clipped. Alternatively we could set this to 'scroll', which will always cause the scrollbar to appear. I think this would be the wrong thing to do, since it would cause it to appear even on non-clipped content, and wouldn't overwrite the Mac OS setting anyway.

I think we can add a little bit of space to the right, but adding too much would make cards without a scrollbar look a bit messy. screenshot from 2019-01-09 12-26-25

melissachang commented 5 years ago

Both screenshots are from Chrome. Agree that scrollbar should not appear for non-clipped content.

Right now, value counts in clipped cards are to the left of where they are for non-clipped cards. Ideally they would be in the same place for clipped and non-clipped -- that is, right-aligned to facet total count.

Right now there's space between scrollbar andn right of card. Ideally scrollbar would move to the right.

melissachang commented 5 years ago

Not an issue with new UI.

1