search

DataBiosphere / data-explorer

BSD 3-Clause "New" or "Revised" License
10 stars 6 forks source link

Fix crashes when searching for a facet with all null values #287

Closed wnojopra closed 5 years ago

wnojopra commented 5 years ago

Fixes #279 Before: Request Errors After:

screenshot from 2019-02-28 10-39-19

melissachang commented 5 years ago

Thanks.

Let's get rid of that horizontal line. In HistogramFacet.js, let's only display the Vega div if values is not empty.

(TextFacet is fine.)

wnojopra commented 5 years ago

Got rid of the line for empty values screenshot from 2019-02-28 14-30-47