Fix query string handling

DataBiosphere / data-explorer

BSD 3-Clause "New" or "Revised" License

11 stars 6 forks source link

Fix query string handling #322

Closed melissachang closed 5 years ago

melissachang commented 5 years ago

I think #321 broke things. I thought I tested it locally, I'm not sure what happened.

Repro:

Go to AMP PD DE and select a bar
Copy url and open in new tab. You get a blank page

I tested this PR locally. I'm deploying now; I'll test on prod soon.

wnojopra commented 5 years ago

What do you think about adding a simple e2e test for query parameters? A barebones one might look like: 1) Click on a facet, check the url is updated as expected 2) goto a url with some query parameters. Make sure the page looks as expected.

In retrospect I probably should have added these tests when I first implemented.

melissachang commented 5 years ago

Excellent idea, done. I confirmed test fails on master and works on this branch