search

DataBiosphere / data-explorer

BSD 3-Clause "New" or "Revised" License
10 stars 6 forks source link

Redesign in preparation for embedding Data Explorer inside Terra #323

Closed melissachang closed 5 years ago

melissachang commented 5 years ago

This PR has been deployed to https://test-data-explorer.appspot.com Move participant count out of header. Change export fab to Save cohort button, to match Terra style. In common.js, create buttons and tooltip that can be used throughout DE.

I deleted TextFacet/viz switch to simplify the UI. e2e tests fail because TextFacet no longer exists. I'll create another PR that deletes TextFacet and converts e2e tests to use HistogramFacet, and merge that before this PR. I wanted to send out this PR for review so you could look at the code.

wnojopra commented 5 years ago

Code wise this lgtm. Appreciate the refactoring changes.

I'll give final approval once the test changes are in.

melissachang commented 5 years ago

Updated, PTAL