DataBiosphere / data-store

AWS and GCP data storage system for genomic data.
https://dss.dev.ucsc-cgp-redwood.org
Other
3 stars 2 forks source link

[EASY] Hotfix to convert admin emails to lowercase #142

Closed chmreid closed 3 years ago

chmreid commented 4 years ago

This PR fixes the way the admin emails are obtained from the Config class so that they are all converted to lowercase when they are grabbed from the env config. It also fixes the way it compares the JWT email claim to the admin emails so that the email claim is also lowercase.

This PR raises questions about other group/email comparison mechanisms in the security class, and whether they would break if an email or group name were capitalized. But that's for another day...