search

DataBiosphere / data-store

AWS and GCP data storage system for genomic data.
https://dss.dev.ucsc-cgp-redwood.org
Other
3 stars 2 forks source link

Implement DRS Get Object for files (closes #86) #162

Closed natanlao closed 4 years ago

natanlao commented 4 years ago

Implements partial support for the DRS Get Object endpoint. This implementation does not permit using the Get Object endpoint to retrieve information on bundles or collections, and is missing access information due to ongoing access control work.

Closes #86

codecov-io commented 4 years ago

Codecov Report

Merging #162 into master will increase coverage by 0.02%. The diff coverage is 85.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #162      +/-   ##
==========================================
+ Coverage   78.15%   78.18%   +0.02%     
==========================================
  Files          93       94       +1     
  Lines        6804     6825      +21     
==========================================
+ Hits         5318     5336      +18     
- Misses       1486     1489       +3
Impacted Files Coverage Δ
dss/api/drs.py 85.71% <85.71%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 91c2730...5216550. Read the comment docs.

natanlao commented 4 years ago

This would also mean that we would need 1 more endpoind, the current one being for the metadata, the other one being actually access the data.

Spoke with @amarjandu over Slack. Since we're only dealing with public files at this point, I'll update the Get Object endpoint to return presigned URLs to files but will not implement the Get Object Access endpoint since there's no point, as all file are already public anyway.