search

DataBiosphere / data-store

AWS and GCP data storage system for genomic data.
https://dss.dev.ucsc-cgp-redwood.org
Other
3 stars 2 forks source link

Remove stage-specific environment variables #64

Closed chmreid closed 4 years ago

chmreid commented 4 years ago

Housekeeping in the environment file...

Removes environment variables (mostly bucket-related) ending with _STAGING, _INTEGRATION, or _PROD from the environment file

amarjandu commented 4 years ago

we can remove them, but lets throw in a comment to the hca/data-store env file to look at one if someone needs a reference for multiple stages.

chmreid commented 4 years ago

Good thinking.

Forgot that these are also referenced in the terraform files, so am taking care of those too.

chmreid commented 4 years ago

Commit ff4cbff adds info about multi-stage deployments to the readme and a few comments in the environment file

codecov-io commented 4 years ago

Codecov Report

Merging #64 into master will not change coverage by %. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #64   +/-   ##
=======================================
  Coverage   78.14%   78.14%           
=======================================
  Files          93       93           
  Lines        6800     6800           
=======================================
  Hits         5314     5314           
  Misses       1486     1486

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3c9b3d0...8c66823. Read the comment docs.