search

DataBiosphere / dos-azul-lambda

Provides access to DSS azul-index in the Data Object Service schemas
https://dos.commons.ucsc-cgp.org
Apache License 2.0
2 stars 2 forks source link

Replace boto with boto3 (closes #73) #117

Closed natanlao closed 5 years ago

natanlao commented 5 years ago

This commit updates app.py and specified dependencies to use boto3 over boto, which allows us to improve our Python 3.x support. In the process of doing so, "manual" calls to ElasticSearch have been replaced with the ElasticSearch Python bindings, which provide more robust logging and error handling.

The provisioning script is also updated to use boto3 and the ElasticSearch bindings.

natanlao commented 5 years ago

This also fixes an (unreported) bug where the is_secure=False flag was used when starting the ElasticSearch connection.

david4096 commented 5 years ago

Great work @natanlao ! This keeps this repository free of legacy code and aligns better with the approach azul has to working with elasticsearch. Using the boto2 client to work with elasticsearch was awkward. Great to see PRs that remove code and make improvements!

natanlao commented 5 years ago

Thanks for the review!