search

DataBiosphere / dsub

Open-source command-line tool to run batch computing tasks and workflows on backend services such as Google Cloud.
Apache License 2.0
265 stars 44 forks source link

+ introduce a service account options #144

Closed indraniel closed 5 years ago

indraniel commented 5 years ago
indraniel commented 5 years ago

Hi. Our Google Cloud setup requires the use of an alternative service account to use with the Google Genomics Pipelines API. To that end I've added a --service-account option to dsub.

Unfortunately, I'm not sure what is the best way to add a test for this new option in this project. Any help and/or assistance would be appreciated.

If this option doesn't fit in with the overall vision/strategy of this project feel free to let me know too.

Thanks in advance!

mbookman commented 5 years ago

Thanks @indraniel. We are still working on our systems for taking community contributions. Apologies for the delay in responding.

We will add the service account field to the next release.

indraniel commented 5 years ago

Sounds good! Feel free to let me know if I need to make any additional changes.

mbookman commented 5 years ago

The --service-account flag is included in https://github.com/DataBiosphere/dsub/releases/tag/v0.2.6.

indraniel commented 5 years ago

Thanks! Does this mean that this pull request is now invalid? Should this pull request be closed then?

mbookman commented 5 years ago

Yes, this PR has been superceded by the change we pushed out. Thanks again!