search

DataBiosphere / dsub

Open-source command-line tool to run batch computing tasks and workflows on backend services such as Google Cloud.
Apache License 2.0
265 stars 44 forks source link

Add type annotations #222

Closed andrewrosss closed 1 year ago

andrewrosss commented 3 years ago

I figure I can start throwing potential changes here (I was going to start with the modules in the dsub.lib sub-package), and if type annotations aren't desirable at the moment then feel free to close #221 and disregard this PR! :)

mbookman commented 3 years ago

Hi @andrewrosss !

It turns out that at the moment, we aren't well set up to take in contributions. We actually develop dsub internally and then push out periodic releases. Was recently noting that we needed to update our CONTRIBUTING.md to reflect this. Will leave this PR open for now to see if it can be a forcing function to update our code flow.

Thanks!

andrewrosss commented 3 years ago

Good to know, thanks for the heads up and thanks again for the useful package!