DataBiosphere / job-manager

Job Manager API and UI for interacting with asynchronous batch jobs and workflows.
BSD 3-Clause "New" or "Revised" License
26 stars 5 forks source link

Factor shared models/utils from shims #392

Open ruchim opened 6 years ago

ruchim commented 6 years ago

Currently, we generate the python flask swagger models in two places. There are also some utilities which we've duplicated across the two shims. Ideally these two shims would call into a shared library.

That said, we want to balance this with isolation of the two projects; I don't think we want to install all cromwell dependencies to run dsub or vice-versa. Possibly this could be achieved with some PYTHONPATH hackery, or else some pip magic.

Issue was raised by @samanehsan and @bryancrampton during code review.

geoffjentry commented 6 years ago

ITYM @bfcrampton