Filter by timestamp - Githubissues

DataBiosphere / job-manager

Job Manager API and UI for interacting with asynchronous batch jobs and workflows.

BSD 3-Clause "New" or "Revised" License

26 stars 5 forks source link

Filter by timestamp #440

Open kbergin opened 6 years ago

kbergin commented 6 years ago

Cromwell API allows filtering by time as well as date. Enable this in the UI date/time picker. Probably needs UX? Not sure if the date picker design has this.

AC: Time picker allows filtering on both start and end time

ruchim commented 5 years ago

@rsasch -- Just can't remember why this was in an Icebox state? If it's blocked on Cromwell, I'd love to get that addressed. If blocked on UX, I can help there as well.

rsasch commented 5 years ago

@ruchim It's blocked on UX and also by the fact that Angular Material has a date-picker out-of-the-box, but no date & time picker (see https://github.com/angular/material2/issues/5648), so this would have to use a library someone else wrote or cobble together something ourselves.

ruchim commented 5 years ago

I think filtering just by date is a great starting point, and valuable on its own since most folks would be able to sufficiently filter by date.

I'll work on getting the UX figured out. Thanks Bec, this will be on deck as soon as the UX is figured out

ruchim commented 5 years ago

rsasch commented 5 years ago

no custom range
no apply button; will be a drop-down, not a series of radio buttons
this will re-purpose the drop-down that is currently only used by the dashboard; will change that drop-down to create a submitted chip, not a start one
once a user has selected a range from the drop-down (or any other date-based filter), it will be converted to a filter chip and the menu will be hidden; if the range chip is cleared, the menu will re-appear
default value is: 7 days (if possible)

ruchim commented 5 years ago

@rsasch -- in the UI, when someone were to adjust the submitted default lets say from 7 days to 30 days, is there a way for Job Manager today to remember how they last set that parameter, so when the page is loaded again, it can use that value as the default?

rsasch commented 5 years ago

@ruchim It can be saved in the browser store settings (see #458).

ruchim commented 5 years ago

Awesome---Marty gave some feedback saying that if we don't add something in the settings bar to set a default --it would be nice for the UI to remember the last submitted range a user set, as a way for them to recreate the same results when loading back into JMUI. Thoughts?

rsasch commented 5 years ago

I don't think there's anything blocking adding a setting in the settings menu for the default submitted value. Is this something that the user should be able to set explicitly?

rsasch commented 5 years ago

Result of F2F chat – no setting that user can change. Browser storage just remembers last setting.