DataBiosphere / leonardo

Notebook service
BSD 3-Clause "New" or "Revised" License
43 stars 21 forks source link

[no ticket] fix unit test #4677

Closed Qi77Qi closed 2 months ago

Qi77Qi commented 2 months ago

Jira ticket: https://broadworkbench.atlassian.net/browse/[ticket_number]

Summary of changes

What

-

Why

-

Testing these changes

What to test

Who tested and where

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 73.92%. Comparing base (f9df012) to head (810524e).

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/DataBiosphere/leonardo/pull/4677/graphs/tree.svg?width=650&height=150&src=pr&token=NZGL9e1XHh&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataBiosphere)](https://app.codecov.io/gh/DataBiosphere/leonardo/pull/4677?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataBiosphere) ```diff @@ Coverage Diff @@ ## develop #4677 +/- ## ============================================ + Coverage 0 73.92% +73.92% ============================================ Files 0 160 +160 Lines 0 14999 +14999 Branches 0 1154 +1154 ============================================ + Hits 0 11088 +11088 - Misses 0 3911 +3911 ``` | [Files](https://app.codecov.io/gh/DataBiosphere/leonardo/pull/4677?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataBiosphere) | Coverage Δ | | |---|---|---| | [...workbench/leonardo/util/BuildHelmChartValues.scala](https://app.codecov.io/gh/DataBiosphere/leonardo/pull/4677?src=pr&el=tree&filepath=http%2Fsrc%2Fmain%2Fscala%2Forg%2Fbroadinstitute%2Fdsde%2Fworkbench%2Fleonardo%2Futil%2FBuildHelmChartValues.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataBiosphere#diff-aHR0cC9zcmMvbWFpbi9zY2FsYS9vcmcvYnJvYWRpbnN0aXR1dGUvZHNkZS93b3JrYmVuY2gvbGVvbmFyZG8vdXRpbC9CdWlsZEhlbG1DaGFydFZhbHVlcy5zY2FsYQ==) | `97.18% <100.00%> (ø)` | | ... and [159 files with indirect coverage changes](https://app.codecov.io/gh/DataBiosphere/leonardo/pull/4677/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataBiosphere) ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/DataBiosphere/leonardo/pull/4677?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataBiosphere). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataBiosphere) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/DataBiosphere/leonardo/pull/4677?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataBiosphere). Last update [f9df012...810524e](https://app.codecov.io/gh/DataBiosphere/leonardo/pull/4677?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataBiosphere). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataBiosphere).
Qi77Qi commented 2 months ago

@mlilynolting think I addressed ur comments...lmk if u have more concerns...