DataBiosphere / leonardo

Notebook service
BSD 3-Clause "New" or "Revised" License
43 stars 21 forks source link

AJ-268: update to latest workbench-libs, which removes trial billing references #4685

Closed davidangb closed 2 months ago

davidangb commented 2 months ago

Jira ticket: https://broadworkbench.atlassian.net/browse/AJ-268

Summary of changes

What

This updates Leo's automation subdirectory (swat tests) to the latest versions of workbench-libs libraries. The latest version of service-test removes knowledge of the trial-billing SA.

This pulls in https://github.com/broadinstitute/workbench-libs/pull/1692

I am making this change across Sam, Leo, Rawls, and Orch:

Why

This is a prerequisite for removing knowledge of trial-billing from the github workflows that run the swat tests, which in turn unblocks removing that unused SA entirely.

Testing these changes

If swat tests continue to pass, these changes are solid.

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 73.92%. Comparing base (ebe9f23) to head (9e7f6c3). Report is 2 commits behind head on develop.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/DataBiosphere/leonardo/pull/4685/graphs/tree.svg?width=650&height=150&src=pr&token=NZGL9e1XHh&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataBiosphere)](https://app.codecov.io/gh/DataBiosphere/leonardo/pull/4685?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataBiosphere) ```diff @@ Coverage Diff @@ ## develop #4685 +/- ## ======================================== Coverage 73.92% 73.92% ======================================== Files 160 160 Lines 14999 14999 Branches 1154 1154 ======================================== Hits 11088 11088 Misses 3911 3911 ``` ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/DataBiosphere/leonardo/pull/4685?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataBiosphere). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataBiosphere) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/DataBiosphere/leonardo/pull/4685?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataBiosphere). Last update [90339c8...9e7f6c3](https://app.codecov.io/gh/DataBiosphere/leonardo/pull/4685?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataBiosphere). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataBiosphere).