DataBiosphere / leonardo

Notebook service
BSD 3-Clause "New" or "Revised" License
43 stars 21 forks source link

ID-1276 Fix bard url value injection to cromwell-runner-app #4709

Closed Ghost-in-a-Jar closed 1 month ago

Ghost-in-a-Jar commented 1 month ago

Jira ticket: https://broadworkbench.atlassian.net/browse/ID-1276

Followup of this PR: https://github.com/DataBiosphere/leonardo/pull/4664

Summary of changes

When I made the last pr above I made a typo, should be referencing bardUrl and not baseUri. This has only been pushed out to dev so far. Terra helmfile chart where this is setup: https://github.com/broadinstitute/terra-helmfile/blob/master/charts/cromwell-runner-app/templates/cromwell-config.yaml#L220

Testing these changes

What to test

After this is merged and terra-helmfile version updated ill try running a workflow on azure in dev.

Who tested and where

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 73.92%. Comparing base (5759fb0) to head (4cd85bf).

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/DataBiosphere/leonardo/pull/4709/graphs/tree.svg?width=650&height=150&src=pr&token=NZGL9e1XHh&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataBiosphere)](https://app.codecov.io/gh/DataBiosphere/leonardo/pull/4709?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataBiosphere) ```diff @@ Coverage Diff @@ ## develop #4709 +/- ## ======================================== Coverage 73.92% 73.92% ======================================== Files 160 160 Lines 15000 15000 Branches 1191 1191 ======================================== Hits 11089 11089 Misses 3911 3911 ``` | [Files](https://app.codecov.io/gh/DataBiosphere/leonardo/pull/4709?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataBiosphere) | Coverage Δ | | |---|---|---| | [...kbench/leonardo/app/CromwellRunnerAppInstall.scala](https://app.codecov.io/gh/DataBiosphere/leonardo/pull/4709?src=pr&el=tree&filepath=http%2Fsrc%2Fmain%2Fscala%2Forg%2Fbroadinstitute%2Fdsde%2Fworkbench%2Fleonardo%2Fapp%2FCromwellRunnerAppInstall.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataBiosphere#diff-aHR0cC9zcmMvbWFpbi9zY2FsYS9vcmcvYnJvYWRpbnN0aXR1dGUvZHNkZS93b3JrYmVuY2gvbGVvbmFyZG8vYXBwL0Nyb213ZWxsUnVubmVyQXBwSW5zdGFsbC5zY2FsYQ==) | `81.25% <ø> (ø)` | | ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/DataBiosphere/leonardo/pull/4709?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataBiosphere). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataBiosphere) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/DataBiosphere/leonardo/pull/4709?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataBiosphere). Last update [5759fb0...4cd85bf](https://app.codecov.io/gh/DataBiosphere/leonardo/pull/4709?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataBiosphere). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataBiosphere).