DataBiosphere / ssds

Simple data storage system for AWS and GCP
MIT License
2 stars 1 forks source link

Copy client reports all failures #207

Closed xbrianh closed 3 years ago

xbrianh commented 3 years ago

The storage.copy_client context manager previously threw an exception upon exit if any number of copies failed, leaving some errors unreported.

This causes it to save, log, and report all copy errors.

codecov-io commented 3 years ago

Codecov Report

Merging #207 into dev will decrease coverage by 0.05%. The diff coverage is 97.91%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #207      +/-   ##
==========================================
- Coverage   86.65%   86.59%   -0.06%     
==========================================
  Files          16       16              
  Lines        1019     1022       +3     
==========================================
+ Hits          883      885       +2     
- Misses        136      137       +1     
Impacted Files Coverage Δ
ssds/storage.py 93.82% <97.22%> (-0.66%) :arrow_down:
ssds/__init__.py 87.06% <100.00%> (+0.46%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ddeb551...0f770c7. Read the comment docs.