search

DataBiosphere / terra-interoperability-model

Common data model proposal for biomedical research intended to facilitate and encourage data sharing and reuse
BSD 3-Clause "New" or "Revised" License
19 stars 2 forks source link

Perturbations #74

Closed rsc3 closed 2 years ago

rsc3 commented 2 years ago

I removed SampleTreatment and GeneticModification as classes. Now pertubations just consist of a series of DataType properties which have domain of BioSample: hasSampleTreatment, hasGeneticModification, hasSampleTreatmentType, hasSampleTreatmentMethod, hasGeneticModifcationType, hasGeneticModificationMethod

I felt that removing SampleTreatment and GeneticModification from being subclasses of activities didn't really give them a reason to exist as separate tables. They are modifications of BioSample, so I thought that is a simpler place to store them.

Happy to discuss modelling perturbations as their own classes.

I did not model hasPurpose, that seemed a bit generic to me and can be tackled later when we have more actual examples of perturbation data.