search

DataBiosphere / terra-interoperability-model

Common data model proposal for biomedical research intended to facilitate and encourage data sharing and reuse
BSD 3-Clause "New" or "Revised" License
19 stars 2 forks source link

Additional updates for cross dataset search #90

Closed kreinold closed 2 years ago

kreinold commented 2 years ago

Please review DM-419 and DM-420. Added definitions for key properties, updated data modality cardinality, fixed some issues with hasGenotypicSex and hasOrganismType.

rsc3 commented 2 years ago

Consider why we are requiring a DataModality for every activity: why must biosample dissociation or sample treatment have a DataModality?

Range for TerraCore:hasGenotypicSex ?

Suggest TerraCore:hasPlatformIdentifier -> TerraCore:hasPlatformID

kreinold commented 2 years ago

Both Identifier and Data Modality are consistent -- with current naming convention and definition of Activity, respectively.