Open joelarmstrong opened 7 years ago
When this error occurs, Toil does not stop the running cluster nodes (see #2196). That makes this bug extremely dangerous.
➤ Melaina Legaspi commented:
Marking this ticket as low priority, we haven’t addressed this in many years.
➤ Melaina Legaspi commented:
Adam Novak :"This needs to be reproduced and the best approach would be to mock the spot market.”
Currently the AWS provisioner will terminate the entire workflow if it hits the spot request limit:
I'd suggest that instead we just drop a warning, (possibly) decrease the number of requested instances, and keep trying without killing the workflow. Users might easily go over their limit without realizing it, especially if they share AWS accounts or have a new AWS account. Unfortunately I can't submit a patch for this, because I can't test if it works, because my spot limit is 0 thanks to the AWS account reshuffle (not that I'm bitter about that :)).
┆Issue is synchronized with this Jira Story ┆Issue Number: TOIL-169