search

DataBiosphere / toil

A scalable, efficient, cross-platform (Linux/macOS) and easy-to-use workflow engine in pure Python.
http://toil.ucsc-cgl.org/.
Apache License 2.0
901 stars 240 forks source link

improve batch scheduler unit testing via mocks and recorded outputs #3864

Open mr-c opened 3 years ago

mr-c commented 3 years ago

gmloose improved the test coverage of slurm.py by using snapshots of outputs of the results of the Slurm command line tools to improve tests coverage without requiring that Slurm be installed

https://github.com/DataBiosphere/toil/pull/3822/files#diff-2e81f7794e695a87c9432d7f92dcd714ae2c738d5a9c55a53d59078fe2b4fafb

This should be done for the other batch systems as well. Especially if we can get samples from different versions and setups

┆Issue is synchronized with this Jira Story ┆Issue Number: TOIL-1059

unito-bot commented 1 week ago

➤ Adam Novak commented:

We can add issues for doing this for the different batch systems under this issue as an epic/parent.

This will probably be a lot of work.

unito-bot commented 1 week ago

➤ Adam Novak commented:

This might be a good thing for the people who actually use these various batch systems to lead, since they could submit example output.