This should fix #4867 by changing the logging and exception handling around bucket location finding.
We now announce finding the location at the same log level as failing to find it (DEBUG), and leave reporting at higher levels up to the caller. Most of the callers seem to have fallback approaches to use when a bucket location isn't available, and so don't have to log anything at a higher level.
Also, to keep the user from getting bored during file imports, I am logging them at INFO:
[ ] New functions or classes without informative docstrings.
[ ] Changes to semantics not reflected in the relevant docstrings.
[ ] New or changed command line options for Toil workflows that are not reflected in docs/running/{cliOptions,cwl,wdl}.rst
[ ] New features without tests.
[ ] Comment on the lines of code where problems exist with a review comment. You can shift-click the line numbers in the diff to select multiple lines.
[ ] Finish the review with an overall description of your opinion.
Merger Checklist
[ ] Make sure the PR passes tests.
[ ] Make sure the PR has been reviewed since its last modification. If not, review it.
[ ] Merge with the Github "Squash and merge" feature.
[ ] If there are multiple authors' commits, add Co-authored-by to give credit to all contributing authors.
[ ] Copy its recommended changelog entry to the Draft Changelog.
[ ] Append the issue number in parentheses to the changelog entry.
This should fix #4867 by changing the logging and exception handling around bucket location finding.
We now announce finding the location at the same log level as failing to find it (DEBUG), and leave reporting at higher levels up to the caller. Most of the callers seem to have fallback approaches to use when a bucket location isn't available, and so don't have to log anything at a higher level.
Also, to keep the user from getting bored during file imports, I am logging them at INFO:
Changelog Entry
To be copied to the draft changelog by merger:
Reviewer Checklist
issues/XXXX-fix-the-thing
in the Toil repo, or from an external repo.camelCase
that want to be insnake_case
.docs/running/{cliOptions,cwl,wdl}.rst
Merger Checklist