search

DataBiosphere / toil

A scalable, efficient, cross-platform (Linux/macOS) and easy-to-use workflow engine in pure Python.
http://toil.ucsc-cgl.org/.
Apache License 2.0
901 stars 240 forks source link

JobServiceTest.testServiceParallelRecursive can time out #5140

Open adamnovak opened 1 month ago

adamnovak commented 1 month ago

As shown in https://ucsc-ci.com/databiosphere/toil/-/jobs/81547, the JobServiceTest.testServiceParallelRecursive test can hit its 1200 second timeout and fail.

I'm beginning to think this is a bad test design; if it is indicating a newly introduced problem it almost certainly wasn't from #5139 which it failed on, and it it isn't then even with all the retry logic around this test it can still fail for no reason.

Maybe we need to demote it to an integration test, or eliminate it altogether in favor of something deterministic.

┆Issue is synchronized with this Jira Story ┆Issue Number: TOIL-1663

adamnovak commented 3 weeks ago

This happened again in https://ucsc-ci.com/databiosphere/toil/-/jobs/82249