DataBrewery / cubes

[NOT MAINTAINED] Light-weight Python OLAP framework for multi-dimensional data analysis

http://cubes.databrewery.org

Other

1.49k stars 314 forks source link

Incomplete and broken unittests #403

Open Stiivi opened 7 years ago

Stiivi commented 7 years ago

Unittests are incomplete and broken. They are in very bad shape. This is a large task to be done.

Tests to be reviewed:

[ ] Metadata
[ ] Cells
[ ] Workspace
[ ] Browser
[ ] SQL
[ ] Server

The list might be broken into several smaller issues and this issue might serve as a 'master issue'.

This is a good opportunity to learn about Cubes internals and give feedback about it's flaws. I am willing to assist to anyone who wants to take care of this issue.

KhaledTo commented 7 years ago

Hi @Stiivi, I would like to work on this.

Stiivi commented 7 years ago

Thank you. Before we do anything with the test suite, I think it would be great if it was restructured to match the project modules (units).

What is your approach? How can I help you?

Btw. if you decide to do it, do it please in the 2.0 branch with Python 3.6.

Stiivi commented 7 years ago

The #408 (Cube Query flow redesign) might have influence on rewriting unittests tests. It should be anticipated that the tests will change. Good news is, that after the redesign the tests are going to be way much cleaner and manageable.

Stiivi commented 7 years ago

407 (removal of Cube from cell) broke tests.

Stiivi commented 7 years ago

Silenced broken unittests in #426 so that CI is passing for now – temporarily for #393, which is now priority.