DataBrewery / cubes

[NOT MAINTAINED] Light-weight Python OLAP framework for multi-dimensional data analysis
http://cubes.databrewery.org
Other
1.49k stars 314 forks source link

Refactor Dimension.from_metadata #412

Open Stiivi opened 7 years ago

Stiivi commented 7 years ago

The Dimension.from_metadata method is overly complex and might also have type issues.

To do:

  1. [ ] analyse the function flow
  2. [ ] split into smaller parts, especially to JSON metadata consolidation and actual object building

Also think about how to introduce correct nomenclature: the dimensions with templates are role-playing dimensions.