Explicitly list instance variables in sql.mapper.Naming

DataBrewery / cubes

[NOT MAINTAINED] Light-weight Python OLAP framework for multi-dimensional data analysis

http://cubes.databrewery.org

Other

1.49k stars 312 forks source link

Explicitly list instance variables in sql.mapper.Naming #420

Closed Stiivi closed 7 years ago

Stiivi commented 7 years ago

Currently Naming is a dictionary. We need to make it a class with explicitly listed instance variables that are used in the mapping process. There is no reason to have it a dictionary besides historical convenience (aka laziness).

Note: At the time of writing this issue this can be done on the sql-annotations-unstable branch of 2.0, since some of the changes were already made.

Stiivi commented 7 years ago

While working on #430 I'm coming to conclusion that the Naming as an object should be removed and kept just as a dictionary with SettingValue values. Interpretation left to backends.

Stiivi commented 7 years ago

Replaced by #431.