fix(key id): send fact key to star scheme.

DataBrewery / cubes

[NOT MAINTAINED] Light-weight Python OLAP framework for multi-dimensional data analysis

http://cubes.databrewery.org

Other

1.49k stars 314 forks source link

Closed maxpospelov closed 5 years ago

maxpospelov commented 6 years ago

Update browser.py

Update query.py

feature (ujson): fast serializer with ugly limit support

Update utils.py

fix (ujson): import for g

jjmontesl commented 5 years ago

Sorry, this pull request introduces several different changes:

Ugly JSON (interesting, but not the topic of the pull request)
Hardcodes an 'id' default for fact keys, which is not documented and not desirable (we should not make up column names)

As the description of this pull request is also not too descriptive, I'm rejecting in its current state.