search

DataCater / datacater

The developer-friendly ETL platform for transforming data in real-time. Based on Apache Kafka® and Kubernetes®.
https://datacater.io
Other
82 stars 4 forks source link

Remove long code duplication #119

Closed HknLof closed 1 year ago

HknLof commented 1 year ago

In our runner.py we now have two function, which almost do the same thing and have a roughly 100 lines duplications. Let's put some effort into cleaning this up in the coming weeks.

Reference: First Block https://github.com/DataCater/datacater/blob/main/python-runner/runner.py#L87

Second Block https://github.com/DataCater/datacater/blob/main/python-runner/runner.py#L209

flippingbits commented 1 year ago

@HknLof and I had a look at this issue in a call. Removing duplicates looks rather complicated. We ignore it for now.