DataCater / datacater

The developer-friendly ETL platform for transforming data in real-time. Based on Apache Kafka® and Kubernetes®.
https://datacater.io
Other
82 stars 4 forks source link

PayloadEditor integration for write operations #191

Closed HknLof closed 1 year ago

HknLof commented 1 year ago

Edit-2: April 20th

The current implementation and state manage follows the approach, that state changes made to the HTML form are synchronized to the payload editor. When changing back form the editor and changes were made, we prompt users to either discard made changes or stay within the editor. If no changes were done, there is no prompt. Generally speaking opening the Edit as JSON button can be found at the bottom of the form.

Screenshot 2023-04-20 at 15 13 46

Exceptions to this rule are the Edit Pipeline window, Edit Config, and New Config containers.

For Edit Pipeline it would have convoluted our pipeline designer. This container already has lots of contents, hence it Edit as JSON is choice before you encounter the Pipeline Designer.

Screenshot 2023-04-20 at 15 13 55

Edit Config and New Config have a slightly special treatment because of the visible tabs. Here, the button Edit as JSON is always visible throughout both tabs.

Screenshot 2023-04-20 at 15 14 05

Will update description with screenshots, once editor draft is implemented.

EDIT-1: Create a second panel for PUT and POST methods ... @flippingbits, will need your guidance to create the same look and feel as ApiCall button. Will implement logic before going into destroying the layout just to fix it again 😄

Screenshot 2023-03-20 at 15 58 09
HknLof commented 1 year ago

@ChrisRousey @flippingbits Grew larger than expected. I did not extract functions for re-use, as this is not being done throughout our UI codebase, [for state management and this references, I guess].

HknLof commented 1 year ago

Thanks for the feedback, I will put this PR to draft and integrate the PayloadEditor into the /**/editcontainers.

HknLof commented 1 year ago

Integrated the <PayloadEditor> into various containers, which perform write operations to our API. Along the way I encountered some issues and housekeeping tasks for our ui implementation, that I would summarize in some tickets.

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information