DataCater / datacater

The developer-friendly ETL platform for transforming data in real-time. Based on Apache Kafka® and Kubernetes®.
https://datacater.io
Other
82 stars 4 forks source link

Implement integration tests for kubernetes #193

Closed ChrisRousey closed 1 year ago

ChrisRousey commented 1 year ago

As of now, we have unit tests for testing application functionalities. There are some functionalities, that can't be tested through unit tests, since they require a actual underlying kubernetes instance. These tests should:

HknLof commented 1 year ago

Usage of Quarkus DevServices for non-mockable calls to Kubernetes as mentioned in the PR #178 . E2E Tests with Kubernetes / minikube will be a separate issue.

ChrisRousey commented 1 year ago

@HknLof @olis1996 The reason we were having problems with the @Ignore annotation, is because @Ignore is Junit4 specific, with Junit5 Jupiter the annotation is @Disabled. We use Junit5 (Jupiter) throughout our tests and don't actually have the junit4 dependency. The io.quarkus:quarkus-test-kubernetes-client brought junit4 with it, which is why we didn't notice. Once we removed the dependency in order to enable the Kubernetes Devservices, it broke those tests.

HknLof commented 1 year ago

Thanks :)

Can we replace @Ignore with @Disable?