search

DataCater / datacater

The developer-friendly ETL platform for transforming data in real-time. Based on Apache Kafka® and Kubernetes®.
https://datacater.io
Other
82 stars 4 forks source link

Frontend: Use Hyperlink `<a>` when appropriate #196

Closed HknLof closed 1 year ago

HknLof commented 1 year ago

We use <a href="#"> a lot in our codebase. This is no functional issue, but we can be cleaner with hyperlink tag usage, by reducing the use to actually navigate to specific places in our UI.

When no navigation is needed it might make sense to replace hyperlink tags with <Button> elements.

HknLof commented 1 year ago

Discuss, whether refactoring this is worth the ROI.

sumitshinde-84 commented 1 year ago

i would like to work on this issue , can you please assign it to me ?

flippingbits commented 1 year ago

Hi @sumitshinde-84 - I assigned you to this issue. Please let us know if you need any help when working on it. We look forward to your PR! 🚀

sumitshinde-84 commented 1 year ago

Thank you so much for assigning this issue to me , I will give my best .

flippingbits commented 1 year ago

Thanks for contributing! Feel free to join our Slack if you have any questions.

ChrisRousey commented 1 year ago

Hey @sumitshinde-84, do you have any questions or need any help so far?

sumitshinde-84 commented 1 year ago

@ChrisRousey Sorry I was busy but now I am gonna work on it.

ChrisRousey commented 1 year ago

@sumitshinde-84 it's fine, do it at your own pace! I just wanted to make sure you get the help and resources you need in case you have any problems or need help setting things up 🙂