search

DataConservancy / dcs-package-ingest

Ingests the contents of Data Conservancy Packages into a Fedora 4 repository.
1 stars 2 forks source link

Flat binaries #9

Closed emetsger closed 8 years ago

emetsger commented 8 years ago

Fix for #8

birkland commented 8 years ago

I get test failures. It looks like the test is referring to a binary file that isn't actually present in the test package?

Tests run: 4, Failures: 0, Errors: 4, Skipped: 0, Time elapsed: 0.21 sec <<< FAILURE! - in org.dataconservancy.packaging .impl.PackageFileAnalyzerTest testBinaryResourceNoContainer(org.dataconservancy.packaging.impl.PackageFileAnalyzerTest) Time elapsed: 0.163 sec <<< ERROR! java.lang.RuntimeException: Error processing non-container binary resources: /mvn/dcs-package-ingest/package-ingest-impl /target/test-classes/test_pkg/data/bin/curl/NoParent.txt (No such file or directory) at java.io.FileInputStream.open0(Native Method) at java.io.FileInputStream.open(FileInputStream.java:195) at java.io.FileInputStream.<init>(FileInputStream.java:138) at org.dataconservancy.packaging.impl.PackageFileAnalyzer.populateFileResource(PackageFileAnalyzer.java:189) at org.dataconservancy.packaging.impl.PackageFileAnalyzer.lambda$getContainerRoots$1(PackageFileAnalyzer.java:11 5) at java.util.Iterator.forEachRemaining(Iterator.java:116) at org.dataconservancy.packaging.impl.PackageFileAnalyzer.getContainerRoots(PackageFileAnalyzer.java:113) at org.dataconservancy.packaging.impl.PackageFileAnalyzerTest.testBinaryResourceNoContainer(PackageFileAnalyzerT est.java:149)

emetsger commented 8 years ago

Fixed. The directory containing the file was ignored, and apparently must be removed from .gitignore for GitHub to process a commit that overrides the .gitignore.

emetsger commented 8 years ago

@birkland ok cleaned up the lint! I'm happy to merge it if you're cool with it