search

DataDog / agent-payload

Payload format description for communication between the agent and the Datadog backend
BSD 3-Clause "New" or "Revised" License
21 stars 19 forks source link

Update logs java protobuf #340

Closed leeavital closed 1 month ago

leeavital commented 2 months ago

What does this PR do?

Updates the logs payload to be generated with a more modern protobuf compiler (it was being generated with 3.5.1, and will now be generated with a 22.x compiler)

In #337 we discovered an older version of the protoc compiler (and thus java codegenerator) was being used. This PR updates the logs payload for java to a more recent version of the protobuf compiler.

The old generated code is not a problem today, but might become an issue if we need to update the protobuf stack for some reason in the future.

Per the version support policy, the wireformat will not change, however the generated code can (and does, in this PR) change which might make integrating these changes hard.

Motivation

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

Reviewer's Checklist

Reviewers: please see the review guidelines.

leeavital commented 2 months ago

Waiting on the backend to verify this is safe LOGSI-105

luchenyuxx commented 2 months ago

Waiting on the backend to verify this is safe LOGSI-105

👋 Hi @leeavital, I'm from logs-ingestion. We don't usually work with dd-agent, so I have some questions to get an idea the scope of this:

  1. could you indicate how we could test it?
  2. What could be the potential problem of the change?
  3. What should be the indicator of the green light?
  4. What kind of tests you have done already?