search

DataDog / ansible-datadog-callback

Ansible callback to get stats & events directly into Datadog http://datadoghq.com
MIT License
93 stars 47 forks source link

allow additional tags to be defined via datadog_tags list in hostvars #43

Closed cjdaniel closed 5 years ago

cjdaniel commented 5 years ago

Add tags from hostvars list datadog_tags to metrics and events, for better organization of Ansible metrics/events in Datadog across a live infrastructure.

Using Ansible in a "pull" architecture (where each host runs Ansible locally on a schedule) this patch allows appropriately tagging each host/environment's Ansible events and metrics.

dabcoder commented 5 years ago

@cjdaniel sorry for the delay, you've closed this, is this because you no longer want this addition to be reviewed?

cjdaniel commented 5 years ago

@dabcoder No worries -- yes, I don't want it to be reviewed. Thank you!

mf-lit commented 4 years ago

@cjdaniel I realise it's been a long time, but having run into the same issue you describe I'm wondering why you withdrew your PR - did you find an alternative way to pass in tags?

cjdaniel commented 4 years ago

@cjdaniel I realise it's been a long time, but having run into the same issue you describe I'm wondering why you withdrew your PR - did you find an alternative way to pass in tags?

It has been too long to remember completely (in fact, we don't even use this anymore) -- but I think we ended up customizing this callback plugin far too much for it to be useful to anybody else. Pretty sure we were still using the callback method. Tags were still defined in hostvars!