DataDog / apigentools

Generate API clients with ease
https://apigentools.readthedocs.io
BSD 3-Clause "New" or "Revised" License
41 stars 16 forks source link

Updating openapi-generator-cli to latest image #243

Closed devinmatte closed 2 years ago

devinmatte commented 2 years ago

Requirements for Contributing to this repository

What does this PR do?

Updating image for access to stringEnum in typescript-fetch output (https://github.com/OpenAPITools/openapi-generator/pull/11976) as it would fix a lot of our usage issues

Description of the Change

Updated the dockerfile to pull a recent version of openapi-generator-cli to allow usage of a new flag. In order to do this I pointed the dockerfile to the newer dockerhub repo of https://hub.docker.com/layers/openapitools/openapi-generator-cli using the latest sha as of today which was https://hub.docker.com/layers/openapitools/openapi-generator-cli/latest/images/sha256-bda9ca9b2d4ad50a41e1b2cdfbb84d7c21ce0e4d9e9b0061718315d9a7321443?context=explore

Alternate Designs

Building our own local image and using that over the global one. We likely will also do that, however, I felt contributing the change back upstream may be beneficial, at least to consider that at least 8 months of changes have been released.

Possible Drawbacks

It appears the resulting output files are building with 6.0.0-SNAPSHOT over 5.0.1-SNAPSHOT of current release, which introduces a lot of changes to resulting files.

Verification Process

Additional Notes

It appears the resulting output files are building with 6.0.0-SNAPSHOT over 5.0.1-SNAPSHOT of current release

Release Notes

Review checklist (to be filled by reviewers)