DataDog / apm-tutorial-golang

Tutorial for Golang applications using the Datadog Agent in popular configurations
Other
12 stars 6 forks source link

dockerfile: docker-compose does not build #5

Open hannahkm opened 1 year ago

hannahkm commented 1 year ago

It seems that the repo, as it currently is, doesn't allow docker-compose to build. The files also don't seem to align entirely with the tutorial document. I found the issue and listed the solution I used below. I propose getting this resolved for future New Hires going through the tutorials!

Looking at the dockerfile.notes file found inside the /notes directory, we see: Also, looking at the dockerfile.calendar file inside the /calendar directory...

The repo currently holds both dockerfiles in the main directory/context. Moving dockerfile.notes into /notes and dockerfile.calendar into /calendar, as the tutorial says, fixes the issues.

In all-docker-compose.yaml, I had to change build > dockerfile for the notes and calendar services to notes/dockerfile.notes and calendar/dockerfile.calendar, respectively. Nothing else needs to be changed, and this is already correct in the tutorial documents.

These changes allowed my docker-compose to build and run!

circleupx commented 9 months ago

Thank you for pointing this out, wasted almost an hour trying to figure out why the docker compose command would not work. I did as you did, moves the files to their respective folders and updated the path in the YAML file.

It would be nice if this was correct, so that the next person doesn't waste their time like we did.