DataDog / browser-sdk

Datadog Browser SDK
Apache License 2.0
279 stars 130 forks source link

♻️ Sends the conf telemetry from preStartRum #2795

Closed amortemousque closed 4 weeks ago

amortemousque commented 1 month ago

Motivation

Now that we collect pre start telemetry (cf PR) we can move configuration sending to preStartRum. This avoid passing the initConfiguration down to startRum.

Changes

Sends configuration telemetry from preStartRum

Testing


I have gone over the contributing documentation.

codecov-commenter commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 93.61%. Comparing base (0783df4) to head (c781722).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2795 +/- ## ======================================= Coverage 93.61% 93.61% ======================================= Files 243 243 Lines 7098 7098 Branches 1583 1583 ======================================= Hits 6645 6645 Misses 453 453 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

cit-pr-commenter[bot] commented 1 month ago

Bundles Sizes Evolution

📦 Bundle Name Base Size Local Size 𝚫 𝚫% Status
Rum 158.74 KiB 158.80 KiB 64 B +0.04%
Logs 57.67 KiB 57.72 KiB 54 B +0.09%
Rum Slim 105.21 KiB 105.27 KiB 64 B +0.06%
Worker 25.21 KiB 25.21 KiB 0 B 0.00%

🚀 CPU Performance | Action Name | Base Average Cpu Time (ms) | Local Average Cpu Time (ms) | 𝚫 | | --- | --- | --- | --- | | addglobalcontext | 0.002 | 0.001 | -0.000 | | addaction | 0.038 | 0.034 | -0.004 | | adderror | 0.035 | 0.042 | 0.007 | | addtiming | 0.001 | 0.001 | 0.000 | | startview | 1.270 | 1.402 | 0.133 | | startstopsessionreplayrecording | 0.942 | 0.807 | -0.135 | | logmessage | 0.006 | 0.005 | -0.001 |
🧠 Memory Performance | Action Name | Base Consumption Memory (bytes) | Local Consumption Memory (bytes) | 𝚫 (bytes) | | --- | --- | --- | --- | | addglobalcontext | 19.68 KiB | 19.43 KiB | -260 B | | addaction | 69.82 KiB | 69.53 KiB | -296 B | | adderror | 86.51 KiB | 85.48 KiB | -1059 B | | addtiming | 17.55 KiB | 16.03 KiB | -1563 B | | startview | 312.30 KiB | 316.71 KiB | 4.41 KiB | | startstopsessionreplayrecording | 12.19 KiB | 12.27 KiB | 77 B | | logmessage | 67.54 KiB | 65.53 KiB | -2058 B |