DataDog / browser-sdk

Datadog Browser SDK
Apache License 2.0
294 stars 131 forks source link

⚗️[RUM-4780] Remote configuration #2799

Closed amortemousque closed 3 months ago

amortemousque commented 3 months ago

Motivation

Add remote configuration capability

Changes

How to test

window.DD_RUM.init({
    remoteConfigurationId: "50d8ba4b-2ac1-481f-b16e-f110699ecf66", // only config available
    enableExperimentalFeatures: ['remote_configuration'],
    ...
})

Testing


I have gone over the contributing documentation.

cit-pr-commenter[bot] commented 3 months ago

Bundles Sizes Evolution

📦 Bundle Name Base Size Local Size 𝚫 𝚫% Status
Rum 159.49 KiB 160.06 KiB 578 B +0.35%
Logs 58.02 KiB 58.07 KiB 46 B +0.08%
Rum Slim 108.07 KiB 108.64 KiB 578 B +0.52%
Worker 25.21 KiB 25.21 KiB 0 B 0.00%

🚀 CPU Performance | Action Name | Base Average Cpu Time (ms) | Local Average Cpu Time (ms) | 𝚫 | | --- | --- | --- | --- | | addglobalcontext | 0.002 | 0.002 | 0.001 | | addaction | 0.050 | 0.053 | 0.004 | | adderror | 0.052 | 0.041 | -0.011 | | addtiming | 0.001 | 0.001 | -0.000 | | startview | 1.427 | 1.185 | -0.242 | | startstopsessionreplayrecording | 1.077 | 1.090 | 0.013 | | logmessage | 0.007 | 0.023 | 0.016 |
🧠 Memory Performance | Action Name | Base Consumption Memory (bytes) | Local Consumption Memory (bytes) | 𝚫 (bytes) | | --- | --- | --- | --- | | addglobalcontext | 19.58 KiB | 19.47 KiB | -116 B | | addaction | 68.97 KiB | 68.50 KiB | -486 B | | adderror | 83.18 KiB | 83.93 KiB | 762 B | | addtiming | 17.24 KiB | 17.73 KiB | 501 B | | startview | 313.58 KiB | 320.50 KiB | 6.92 KiB | | startstopsessionreplayrecording | 11.51 KiB | 11.99 KiB | 499 B | | logmessage | 64.11 KiB | 66.83 KiB | 2.72 KiB |
codecov-commenter commented 3 months ago

Codecov Report

Attention: Patch coverage is 97.91667% with 1 line in your changes missing coverage. Please review.

Project coverage is 93.66%. Comparing base (b839f8c) to head (3ad4673).

Files Patch % Lines
...re/src/domain/configuration/remoteConfiguration.ts 94.44% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2799 +/- ## ========================================== + Coverage 93.65% 93.66% +0.01% ========================================== Files 243 244 +1 Lines 7140 7168 +28 Branches 1599 1603 +4 ========================================== + Hits 6687 6714 +27 - Misses 453 454 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

amortemousque commented 3 months ago

/to-staging

dd-devflow[bot] commented 3 months ago

:steam_locomotive: Branch Integration: starting soon, median merge time is 10m

Commit 10bc671246 will soon be integrated into staging-24.

Use /to-staging -c to cancel this operation!

dd-devflow[bot] commented 3 months ago

:steam_locomotive: Branch Integration: This commit was successfully integrated

Commit 10bc671246 has been merged into staging-24 in merge commit 4e239e6834.

Check out the triggered pipeline on Gitlab :fox_face: