Closed nulrich closed 2 months ago
📦 Bundle Name | Base Size | Local Size | 𝚫 | 𝚫% | Status |
---|---|---|---|---|---|
Rum | 160.65 KiB | 160.75 KiB | 103 B | +0.06% | ✅ |
Logs | 57.96 KiB | 57.96 KiB | 0 B | 0.00% | ✅ |
Rum Slim | 109.18 KiB | 109.28 KiB | 103 B | +0.09% | ✅ |
Worker | 25.21 KiB | 25.21 KiB | 0 B | 0.00% | ✅ |
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 93.33%. Comparing base (
fbb4822
) to head (105b983
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Looks good!
I think we should think about naming convention at some point though. For instance, in the different collections, we have processXXX()
method that returns RawRumXXXEvent
. However, the input type names follow different conventions:
Sometime prefix with Raw
, sometimes is suffixed with Event
, sometime no prefix or suffix:
/to-staging
:steam_locomotive: Branch Integration: starting soon, median merge time is 0s
Commit 2d2287d2f1 will soon be integrated into staging-25.
Use /to-staging -c
to cancel this operation!
:steam_locomotive: Branch Integration: This commit was successfully integrated
Commit 2d2287d2f1 has been merged into staging-25 in merge commit 24604054e7.
/to-staging
:steam_locomotive: Branch Integration: starting soon, median merge time is 0s
Commit 105b983568 will soon be integrated into staging-28.
Use /to-staging -c
to cancel this operation!
:steam_locomotive: Branch Integration: This commit was successfully integrated
Commit 105b983568 has been merged into staging-28 in merge commit b26d16995d.
Motivation
We would like to be able to report concurrent vitals with the same name and allowing better visualisations.
Changes
Update custom vital structure:
The custom vital value is now in
duration
field instead of incustom
object.Update custom vital API:
startDurationVital
now returns a vital instance that is used to stop the vital instead of callingstopDurationVital
.Introducing
addDurationVital
to create a vital with a custom duration and startVital values.Both methods now have a
details
attribute that can be used to differentiate vitals using the same name.Testing
I have gone over the contributing documentation.