DataDog / browser-sdk

Datadog Browser SDK
Apache License 2.0
279 stars 130 forks source link

🐛 fix developer extension crashing when dev mode enabled #2810

Closed thomas-lebeau closed 3 weeks ago

thomas-lebeau commented 3 weeks ago

Motivation

Fix issue with the developer extension when dev mode option is enabled:

Screenshot 2024-06-14 at 12 36 36

Changes

Makes sure _setDebug exists before calling it (same as in overrideInitConfiguration)

Testing


I have gone over the contributing documentation.

thomas-lebeau commented 3 weeks ago

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @thomas-lebeau and the rest of your teammates on Graphite Graphite

cit-pr-commenter[bot] commented 3 weeks ago

Bundles Sizes Evolution

📦 Bundle Name Base Size Local Size 𝚫 𝚫% Status
Rum 160.13 KiB 160.13 KiB 0 B 0.00%
Logs 58.07 KiB 58.07 KiB 0 B 0.00%
Rum Slim 108.65 KiB 108.65 KiB 0 B 0.00%
Worker 25.21 KiB 25.21 KiB 0 B 0.00%

🚀 CPU Performance | Action Name | Base Average Cpu Time (ms) | Local Average Cpu Time (ms) | 𝚫 | | --- | --- | --- | --- | | addglobalcontext | 0.001 | 0.001 | 0.000 | | addaction | 0.036 | 0.031 | -0.005 | | adderror | 0.033 | 0.035 | 0.002 | | addtiming | 0.001 | 0.001 | 0.000 | | startview | 0.955 | 1.104 | 0.149 | | startstopsessionreplayrecording | 0.805 | 0.913 | 0.108 | | logmessage | 0.020 | 0.020 | 0.000 |
🧠 Memory Performance | Action Name | Base Consumption Memory (bytes) | Local Consumption Memory (bytes) | 𝚫 (bytes) | | --- | --- | --- | --- | | addglobalcontext | 19.56 KiB | 19.87 KiB | 322 B | | addaction | 69.05 KiB | 69.81 KiB | 777 B | | adderror | 84.02 KiB | 86.25 KiB | 2.23 KiB | | addtiming | 18.22 KiB | 16.66 KiB | -1595 B | | startview | 313.07 KiB | 320.69 KiB | 7.61 KiB | | startstopsessionreplayrecording | 12.84 KiB | 10.61 KiB | -2284 B | | logmessage | 68.11 KiB | 67.38 KiB | -751 B |

🔗 RealWorld