DataDog / browser-sdk

Datadog Browser SDK
Apache License 2.0
279 stars 130 forks source link

🎨 [RUM-5019] Harmonize test mocks #2822

Closed amortemousque closed 1 week ago

amortemousque commented 2 weeks ago

Motivation

Our tests require to mock native APIs, we sometimes calls them stub or mock without a clear understanding of the different (ex: stubStorage.ts, mockLocation.ts).

This PR harmonize the namings of mocks for every test helper located in test/emulate

Changes

Rename:

Split: test/requests.ts => test/emulate/mockFetch.ts, test/emulate/mockXhr.ts and test/interceptRequests.ts

Testing


I have gone over the contributing documentation.

cit-pr-commenter[bot] commented 2 weeks ago

Bundles Sizes Evolution

📦 Bundle Name Base Size Local Size 𝚫 𝚫% Status
Rum 160.50 KiB 160.50 KiB 0 B 0.00%
Logs 58.09 KiB 58.09 KiB 0 B 0.00%
Rum Slim 109.02 KiB 109.02 KiB 0 B 0.00%
Worker 25.21 KiB 25.21 KiB 0 B 0.00%

🚀 CPU Performance | Action Name | Base Average Cpu Time (ms) | Local Average Cpu Time (ms) | 𝚫 | | --- | --- | --- | --- | | addglobalcontext | 0.002 | 0.002 | -0.000 | | addaction | 0.041 | 0.061 | 0.020 | | adderror | 0.035 | 0.059 | 0.025 | | addtiming | 0.001 | 0.001 | 0.000 | | startview | 1.366 | 1.753 | 0.387 | | startstopsessionreplayrecording | 1.314 | 1.326 | 0.012 | | logmessage | 0.025 | 0.021 | -0.004 |
🧠 Memory Performance | Action Name | Base Consumption Memory (bytes) | Local Consumption Memory (bytes) | 𝚫 (bytes) | | --- | --- | --- | --- | | addglobalcontext | 21.76 KiB | 23.10 KiB | 1.34 KiB | | addaction | 72.60 KiB | 71.97 KiB | -652 B | | adderror | 87.25 KiB | 87.52 KiB | 277 B | | addtiming | 19.85 KiB | 21.02 KiB | 1.17 KiB | | startview | 313.18 KiB | 320.31 KiB | 7.13 KiB | | startstopsessionreplayrecording | 16.31 KiB | 16.04 KiB | -276 B | | logmessage | 70.97 KiB | 69.23 KiB | -1782 B |

🔗 RealWorld