Closed BenoitZugmeyer closed 3 months ago
📦 Bundle Name | Base Size | Local Size | 𝚫 | 𝚫% | Status |
---|---|---|---|---|---|
Rum | 160.40 KiB | 160.40 KiB | 0 B | 0.00% | ✅ |
Logs | 58.02 KiB | 58.02 KiB | 0 B | 0.00% | ✅ |
Rum Slim | 108.92 KiB | 108.92 KiB | 0 B | 0.00% | ✅ |
Worker | 25.21 KiB | 25.21 KiB | 0 B | 0.00% | ✅ |
I just realised that in my test app I'm getting a type error:
error TS2345: Argument of type 'import("/Users/nazim.saouli/test-react-app/node_modules/@remix-run/router/dist/router").Router' is not assignable to parameter of type 'import("/Users/nazim.saouli/go/src/github.com/DataDog/browser-sdk/node_modules/@remix-run/router/dist/router").Router'.
Types of property '_internalActiveDeferreds' are incompatible.
Type 'Map<string, import("/Users/nazim.saouli/test-react-app/node_modules/@remix-run/router/dist/utils").DeferredData>' is not assignable to type 'Map<string, import("/Users/nazim.saouli/go/src/github.com/DataDog/browser-sdk/node_modules/@remix-run/router/dist/utils").DeferredData>'.
Type 'import("/Users/nazim.saouli/test-react-app/node_modules/@remix-run/router/dist/utils").DeferredData' is not assignable to type 'import("/Users/nazim.saouli/go/src/github.com/DataDog/browser-sdk/node_modules/@remix-run/router/dist/utils").DeferredData'.
Types have separate declarations of a private property 'pendingKeysSet'.
13 registerRouter(router);
~~~~~~
EDIT:
~I'm still looking around to try and see if it's on me or if that's something that needs to be fixed in the react sdk itself.~
I was testing using npm link
. When I switched to using npm pack
and then npm install
from the tarball it generated the type error is gone.
Attention: Patch coverage is 98.21429%
with 2 lines
in your changes missing coverage. Please review.
Project coverage is 93.20%. Comparing base (
fab7ead
) to head (b228575
). Report is 2 commits behind head on main.
Files | Patch % | Lines |
---|---|---|
...rum-react/src/domain/reactRouterV6/createRouter.ts | 86.66% | 2 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
/to-staging
:steam_locomotive: Branch Integration: starting soon, median merge time is 0s
Commit b228575b7c will soon be integrated into staging-26.
Use /to-staging -c
to cancel this operation!
:steam_locomotive: Branch Integration: This commit was successfully integrated
Commit b228575b7c has been merged into staging-26 in merge commit d7bd0cffcd.
Motivation
Easily instrument a React application with the RUM SDK.
Changes
This PR introduce a new
@datadog/browser-rum-react
package, with error tracking and react-router integration capabilities. More to come in the future.Please review commit by commit.
Testing
I have gone over the contributing documentation.