DataDog / browser-sdk

Datadog Browser SDK
Apache License 2.0
279 stars 130 forks source link

👷‍♀ Remove experimental feature flag for action name privacy control #2831

Closed cy-moi closed 1 week ago

cy-moi commented 1 week ago

Motivation

Make enablePrivacyForActionName feature not behind experimental feature flag.

Changes

Remove experimental feature flag enable_privacy_for_action_name and remove the checks.

Testing


I have gone over the contributing documentation.

cit-pr-commenter[bot] commented 1 week ago

Bundles Sizes Evolution

📦 Bundle Name Base Size Local Size 𝚫 𝚫% Status
Rum 160.50 KiB 160.40 KiB -105 B -0.06%
Logs 58.09 KiB 58.02 KiB -66 B -0.11%
Rum Slim 109.02 KiB 108.92 KiB -105 B -0.09%
Worker 25.21 KiB 25.21 KiB 0 B 0.00%

🚀 CPU Performance | Action Name | Base Average Cpu Time (ms) | Local Average Cpu Time (ms) | 𝚫 | | --- | --- | --- | --- | | addglobalcontext | 0.002 | 0.001 | -0.000 | | addaction | 0.037 | 0.031 | -0.006 | | adderror | 0.033 | 0.039 | 0.007 | | addtiming | 0.001 | 0.001 | 0.000 | | startview | 0.931 | 0.994 | 0.063 | | startstopsessionreplayrecording | 0.904 | 1.081 | 0.177 | | logmessage | 0.022 | 0.023 | 0.002 |
🧠 Memory Performance | Action Name | Base Consumption Memory (bytes) | Local Consumption Memory (bytes) | 𝚫 (bytes) | | --- | --- | --- | --- | | addglobalcontext | 19.95 KiB | 22.14 KiB | 2.19 KiB | | addaction | 70.07 KiB | 67.66 KiB | -2475 B | | adderror | 84.31 KiB | 85.95 KiB | 1.64 KiB | | addtiming | 17.06 KiB | 19.40 KiB | 2.34 KiB | | startview | 313.58 KiB | 319.63 KiB | 6.05 KiB | | startstopsessionreplayrecording | 11.79 KiB | 13.67 KiB | 1.88 KiB | | logmessage | 66.06 KiB | 69.63 KiB | 3.57 KiB |

🔗 RealWorld

RomanGaignault commented 1 week ago