DataDog / chef-datadog

Chef cookbook for Datadog Agent & Integrations
https://www.datadoghq.com
Apache License 2.0
97 stars 262 forks source link

pin jaro_winkler version #921

Closed AliDatadog closed 3 months ago

AliDatadog commented 3 months ago

What does this PR do?

This PR fixes a dependency issue met with my Mac M1.

Running bundle install resolves jaro_winkler 1.5.4 which doesn't compile

An error occurred while installing jaro_winkler (1.5.4), and Bundler cannot continue.

In Gemfile:
  cookstyle was resolved to 6.1.6, which depends on
    rubocop was resolved to 0.80.1, which depends on
      jaro_winkler

Compile error:

jaro_winkler.c:19:3: error: incompatible function pointer types passing 'VALUE (size_t, VALUE *, VALUE)' (aka 'unsigned long (unsigned long, unsigned long *, unsigned long)') to parameter
of type 'VALUE (*)(int, union (unnamed union at /Users/user/.rbenv/versions/3.1.4/include/ruby-3.1.0/ruby/internal/anyargs.h:270:1), VALUE)' (aka 'unsigned long (*)(int, union
(unnamed at /Users/user/.rbenv/versions/3.1.4/include/ruby-3.1.0/ruby/internal/anyargs.h:270:1), unsigned long)') [-Wincompatible-function-pointer-types]

It is fixed by 1.5.6

Motivation

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

Reviewer's Checklist