search

DataDog / cloudformation-template

Easily set up the Datadog AWS integration using CloudFormation
Apache License 2.0
34 stars 42 forks source link

New updates in datadog_integration_api_call_v2.yaml make the lambda failed to update integration and then delete integration #107

Closed JustinLiang90 closed 1 month ago

JustinLiang90 commented 2 months ago

Expected Behavior

The lambda embedded in the datadog_integration_api_call_v2.yaml should return SUCCESS not FAILED if Update not supported, no operation performed. So that it will not return error to the AWS Cloudformation deployment, then it won't block the stack deployment to continue.

Actual Behavior

Our AWS Cloudformation deployment failed because of the embedded lambda in datadog_integration_api_call_v2.yaml returns 400 bad request because of Update not supported, no operation performed.

This makes the AWS Cloudformation trigger rollback and delete the entire Datadog integration in the following action. See the below screenshot, the log is printted by the lambda itself.

We cannot re-created the integration because it may be deleted again after get Update not supported, no operation performed. error.

Screenshot 2024-05-05 at 8 32 57 PM

Steps to Reproduce the Problem

  1. Deploy previous version of a stack based on datadog_integration_api_call_v2.yaml.
  2. Try to update the stack (pulling the latest version of the file).
  3. See it fail because it does not support update.

Specifications

Stacktrace

  Update not supported, no operation performed.

Related PR

https://github.com/DataDog/cloudformation-template/pull/100

danny-fairly commented 1 month ago

Also seeing this. A DD stack we have that is configured with the below TemplateURL now fails to deploy with the latest changes in the template:

TemplateURL: 'https://datadog-cloudformation-template-quickstart.s3.amazonaws.com/aws/datadog_integration_api_call_v2.yaml
sabiurr commented 1 month ago

This has been reverted https://github.com/DataDog/cloudformation-template/pull/111

can you try again and see if it is fixed?

JustinLiang90 commented 1 month ago

It works for now. Thank you!!