search

DataDog / cloudformation-template

Easily set up the Datadog AWS integration using CloudFormation
Apache License 2.0
34 stars 44 forks source link

[aws-streams] adding kms encryption and public access block to s3 bucket #47

Closed jvanbrie closed 2 years ago

jvanbrie commented 2 years ago

Note: Please remember to review the contribution guidelines if you have not yet done so.

What does this PR do?

Blocks public access to the kinesis firehose error bucket. Adds kms encryption as well.

Testing

Confirmed on the demo account - using the cf template to make a new stream, confirmed that when the kinesis firehose fails to write we correctly write to the s3 bucket, and that when the firehose recovers we go back to writing to the datadog endpoint correctly.