search

DataDog / cloudformation-template

Easily set up the Datadog AWS integration using CloudFormation
Apache License 2.0
34 stars 42 forks source link

Unexpected change to template parameters for template in bucket datadog-cloudformation-template #57

Closed plumdog closed 1 year ago

plumdog commented 1 year ago

Expected Behavior

https://datadog-cloudformation-template.s3.amazonaws.com/aws/datadog_integration_role.yaml to be https://raw.githubusercontent.com/DataDog/cloudformation-template/master/aws/datadog_integration_role.yaml

Actual Behavior

They are not the same.

Steps to Reproduce the Problem

$ curl --silent 'https://datadog-cloudformation-template.s3.amazonaws.com/aws/datadog_integration_role.yaml' | yq eval '.Parameters | keys'
- ExternalId
- IAMRoleName
- CloudSecurityPostureManagementPermissions
- DdAWSAccountId

vs

$ curl --silent 'https://raw.githubusercontent.com/DataDog/cloudformation-template/master/aws/datadog_integration_role.yaml' | yq eval '.Parameters | keys'
- ExternalId
- IAMRoleName
- BasePermissions
- LogArchives
- CloudTrails
- CloudSecurityPostureManagementPermissions
- DdAWSAccountId
plumdog commented 1 year ago

My testing suggests this has been quietly fixed:

$ curl --silent 'https://datadog-cloudformation-template.s3.amazonaws.com/aws/datadog_integration_role.yaml' | yq eval '.Parameters | keys'
- ExternalId
- IAMRoleName
- BasePermissions
- LogArchives
- CloudTrails
- CloudSecurityPostureManagementPermissions
- DdAWSAccountId

Thank you, silent fixer.